search

jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.5k stars 88 forks source link

v2.4.2 breaks osc on external players #321

Closed Bestfast closed 1 year ago

Bestfast commented 1 year ago

Describe the bug As title says, no osc is showing with 2.4.2. Reverting to 2.2.0 I can see it. Tried with mpv.net with https://github.com/maoiscat/mpv-osc-modern/

iwalton3 commented 1 year ago

https://github.com/jellyfin/jellyfin-mpv-shim/issues/320

Should be a duplicate of the issue above

iwalton3 commented 1 year ago

Also would you like me to port the MPV Shim trickplay previews to work with that specific OSC?

Bestfast commented 1 year ago

320

Should be a duplicate of the issue above

sorry, didn't check for previous issues. my bad.

Also would you like me to port the MPV Shim trickplay previews to work with that specific OSC?

if you could that would help a lot, feel free to close as a duplicate though

iwalton3 commented 1 year ago

Here is a version of that osc which uses my thumbnail seek provider: https://github.com/iwalton3/mpv-osc-modern/

iwalton3 commented 1 year ago

It you install the latest CI version the above script has been tested and is known to work. Follow the directions in the README. Specifically you need to configure an alternate OSC and install the font.

iwalton3 commented 1 year ago

Update 2: I added a compatibility layer so that Jellyfin MPV Shim will do trickplay with any third-party OSC which works with https://github.com/po5/thumbfast.

To do this, just download one of the OSCs, place it in the scripts folder, and disable the thumbnail_osc_builtin option.