search

jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.5k stars 88 forks source link

[macOS] Unable to set video playback filters #356

Open glottisfaun0000 opened 6 months ago

glottisfaun0000 commented 6 months ago

After installing on macOS using the installation steps with brew and pip3, the one feature I can't get working is the filters like Anime4k. Here's what the output says when I try to select a filter in the c menu:

2023-12-19 18:00:55,903 [ WARNING] player: Error when processing client-message.
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/jellyfin_mpv_shim/player.py", line 445, in handle_client_message
    self.menu.menu_action("ok")
  File "/opt/homebrew/lib/python3.11/site-packages/jellyfin_mpv_shim/menu.py", line 247, in menu_action
    self.menu_list[self.menu_selection][1]()
  File "/opt/homebrew/lib/python3.11/site-packages/jellyfin_mpv_shim/video_profile.py", line 179, in menu_handle
    settings_were_successful = self.load_profile(profile_name)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/jellyfin_mpv_shim/video_profile.py", line 148, in load_profile
    setattr(self.player, key, value)
  File "/opt/homebrew/lib/python3.11/site-packages/python_mpv_jsonipc.py", line 648, in __setattr__
    return self.command("set_property", name.replace("_", "-"), value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/python_mpv_jsonipc.py", line 639, in command
    return self.mpv_inter.command(command, *args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/python_mpv_jsonipc.py", line 347, in command
    raise MPVError(data["error"])
python_mpv_jsonipc.MPVError: unsupported format for accessing property

Tried in and out of a venv, same result. Any ideas?

L3tum commented 3 months ago

Interestingly I have the same issue on Windows, just with a different error of "Could not open file ''".

Ryptahi commented 2 months ago

After installing on macOS using the installation steps with brew and pip3, the one feature I can't get working is the filters like Anime4k. Here's what the output says when I try to select a filter in the c menu:

2023-12-19 18:00:55,903 [ WARNING] player: Error when processing client-message.
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/jellyfin_mpv_shim/player.py", line 445, in handle_client_message
    self.menu.menu_action("ok")
  File "/opt/homebrew/lib/python3.11/site-packages/jellyfin_mpv_shim/menu.py", line 247, in menu_action
    self.menu_list[self.menu_selection][1]()
  File "/opt/homebrew/lib/python3.11/site-packages/jellyfin_mpv_shim/video_profile.py", line 179, in menu_handle
    settings_were_successful = self.load_profile(profile_name)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/jellyfin_mpv_shim/video_profile.py", line 148, in load_profile
    setattr(self.player, key, value)
  File "/opt/homebrew/lib/python3.11/site-packages/python_mpv_jsonipc.py", line 648, in __setattr__
    return self.command("set_property", name.replace("_", "-"), value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/python_mpv_jsonipc.py", line 639, in command
    return self.mpv_inter.command(command, *args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/python_mpv_jsonipc.py", line 347, in command
    raise MPVError(data["error"])
python_mpv_jsonipc.MPVError: unsupported format for accessing property

Tried in and out of a venv, same result. Any ideas?

Had same issue. I was able to get the shaders like anime4k working by going to jellyfin-mpv-shim folder and using the anime4k input as normal to change to correct shader. Seems like it will remember the one you changed to previously. Not ideal solution, but good enough at least for me.