search

jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.63k stars 93 forks source link

SyncPlay support? #65

Closed ThatNerdyPikachu closed 4 years ago

ThatNerdyPikachu commented 4 years ago

Does this support the upcoming SyncPlay feature, or will it require implementing a new API endpoint? (Not sure how it controls playback, if Jellyfin already has an API for this (that MPV Shim would already support, being a Jellyfin client), or if it was implemented just for SyncPlay)

iwalton3 commented 4 years ago

I haven't investigated it yet. I was planning on waiting for the PR to be finalized and merged to implement support if additional work is needed.

ThatNerdyPikachu commented 4 years ago

Gotcha. As far as I can tell, I doubt there will be any underlying implementation changes, maybe just some code cleanup, so I'd say it's fair game to start looking at in now. (I could be completely wrong of course, though)

I'll take a look whenever I can.

mcarlton00 commented 4 years ago

I don't mean to discourage, but maybe hold on spending any significant time implementing this until after 10.6 releases. I started looking into adding support for Kodi and found several things about the API that we didn't like and are changing before release. Just throwing that out there before anybody invests a bunch of time into it.

iwalton3 commented 4 years ago

@mcarlton00 Any update on API stability and changes? Is the API (relatively) stable now that 10.6 is released?

mcarlton00 commented 4 years ago

It should be. The brunt of the API endpoints are going to be found here (not written up nicely anywhere yet. That's on my todo list once I figure out how to get it into Kodi).

Note that there's currently a limitation that you can only create a group once media is already playing. There's an open PR adding this, but it didn't make it into 10.6.0.

ghost commented 4 years ago

@iwalton3 This would be a killer feature to have because this is currently the only desktop client on Windows that can Direct Play HEVC media files. 👍

iwalton3 commented 4 years ago

This was implemented in 1.7.0.