search

jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.59k stars 93 forks source link

Create the external player when required rather than at start. #66

Open adavier opened 4 years ago

adavier commented 4 years ago

The shim seems to require that MPV be open before the shim is started. This means that if it is closed the shim must be restarted. It also results in the window needing to be kept in the background.

Describe the solution you'd like Ideally the external player would be created only when a video is to be started (much like the internal player), then it can be closed when finished.

I have tried this with both external MPV and MPV.net on Windows 10.

MPV.net otherwise works well with the shim, and offers a slightly more user friendly configuration than straight MPV.

iwalton3 commented 4 years ago

I've thought about this as a mitigation for https://github.com/iwalton3/plex-mpv-shim/issues/18, but there would be a ton of refactoring required to do this. I don't anticipate this becoming a feature any time soon.

iwalton3 commented 4 years ago

Since the main goal of this was to get MPV.net working optimally, can you tell me if it respects the same command arguments as regular MPV? Usually these players have to be configured and started by the user separately.

The MPV restart issue is something I really need to address, since I have a copy of this program that is using 2.9 GB on idle because of MPV's idle memory usage. I'll probably also make it so that external MPV is started with the default config ignored, instead only using the mpv shim one. (This would be configurable.)