Refactor jellyfin-packaging

jellyfin / jellyfin-packaging

Jellyfin Packaging and Build Workflows

GNU General Public License v3.0

16 stars 16 forks source link

Refactor jellyfin-packaging #1

Closed Gauvino closed 6 months ago

Gauvino commented 6 months ago

Fix typo in the README
Added -f to rm from fix https://github.com/jellyfin/jellyfin/pull/11008
Apply fix from https://github.com/jellyfin/jellyfin/pull/10763
Refactor Docker for better syntax and readability
Update Intel runtime drivers to 24.05.28454.6
Added possible miss line 159 docker/Dockerfile : "--ffmpeg", "/usr/lib/jellyfin-ffmpeg/ffmpeg"
Removed wget in cleanup
Removed appt-transport-https since it's not needed after Debian buster version

Gauvino commented 6 months ago

Couldn't test to build the dockerfile with the build.py script maybe im missing something if you could help trying to test the image.

Execute this command : python3 build.py debian docker only v10.9.0

Get this error:

#16 [server 4/4] RUN dotnet publish Jellyfin.Server --configuration Release     --output="/server" --self-contained     --runtime linux-x64 -p:DebugSymbols=false -p:DebugType=none
#16 1.986 MSBuild version 17.9.4+90725d08d for .NET
#16 1.998 MSBUILD : error MSB1009: Project file does not exist.
#16 1.998 Switch: Jellyfin.Server
#16 ERROR: process "/bin/sh -c dotnet publish Jellyfin.Server --configuration Release     --output=\"${ARTIFACT_DIR}\" --self-contained     --runtime linux-${DOTNET_ARCH} -p:DebugSymbols=false -p:DebugType=none" did not complete successfully: exit code: 1

Gauvino commented 6 months ago

Sorry but im basically french and the grammar rule are different so I make mistake.

And for this line what should we do keep it like this are change like the others https://github.com/jellyfin-sandbox/jellyfin-packaging/blob/c005fa0d0f5dac21d67944bfb02e580372b225eb/debian/docker/Dockerfile#L72

joshuaboniface commented 6 months ago

For that one I think splitting it into separate lines is also good. I'm not worried about line count as much as readability, but a lot of it I just copy+pasted from the existing Dockerfiles and such and never did a second pass to clean all that up.

Gauvino commented 6 months ago

For that one I think splitting it into separate lines is also good. I'm not worried about line count as much as readability, but a lot of it I just copy+pasted from the existing Dockerfiles and such and never did a second pass to clean all that up.

Fixed !

nyanmisaka commented 6 months ago

@Gauvino You seem to have missed this one. https://github.com/jellyfin/jellyfin-metapackages/pull/40/files

Gauvino commented 6 months ago

@Gauvino You seem to have missed this one. https://github.com/jellyfin/jellyfin-metapackages/pull/40/files

Of course, I'm gonna fix this when I'm back home !