Portable Windows builds aren't actually windows builds

jellyfin / jellyfin-packaging

Jellyfin Packaging and Build Workflows

GNU General Public License v3.0

16 stars 15 forks source link

Portable Windows builds aren't actually windows builds #35

Closed crobibero closed 4 days ago

crobibero commented 1 month ago

Compare contents of 10.8.9 release: https://repo.jellyfin.org/archive/server/windows/stable/10.8.9/combined/jellyfin_10.8.9.zip

to the contents of the 10.9.9 release: https://repo.jellyfin.org/files/server/windows/latest-stable/amd64/jellyfin_10.9.9-amd64.zip

joshuaboniface commented 4 weeks ago

Does 10.9.8 have the .exe? Given that the installer (persumably) works not sure how this failed.

MarkRK commented 4 weeks ago

The 10.9.8 zipfile does not contain the jellyfin.exe.

gnattu commented 4 weeks ago

It is there from the file https://repo.jellyfin.org/files/server/windows/latest-stable/amd64/jellyfin_10.9.9-amd64.zip.

I guess it is something like the windows defender isolated the jellyfin.exe after unzipping.

gnattu commented 4 weeks ago

Another side note is that our current website/document is very very bad regarding the portable builds.

Because we have two kind of builds called "portable" which will confuse our users.

The "portable" in dotnet definition of portable. Which is meant to be run with user-supplied dotnet runtime and ffmpeg
The self-contained platform specific "portable" which is simply the tarball/zipfile of the server folder without extra packaging like making an installer or an app bundle. This one will contain ffmpeg and dotnet runtime.

The user may get confused on which to download because our document only says "portable" and the user could end up downloading the wrong one. I think we should move the portable build out of the OS section and have its own "OS" title.

crobibero commented 3 weeks ago

Ah- the actual issue is that the website doesn't link to the correct "portable" download

https://jellyfin.org/downloads/windows -> https://repo.jellyfin.org/?path=/server/portable/latest-stable

Guess the website just needs to be updated

gnattu commented 3 weeks ago

I have a proposal for this here: https://github.com/jellyfin/jellyfin.org/pull/1077

The current way is just confusing. The portable in the download section is not the platform-spciefic portable but the dotnet portable that will confuse a lot of people.

crobibero commented 4 days ago

Documentation has been updated