search

jellyfin / jellyfin-plugin-dlna

GNU General Public License v3.0
23 stars 13 forks source link

DeviceProfiles: Non-nullable field set to null. #13

Open BaronGreenback opened 3 years ago

BaronGreenback commented 3 years ago

Come across this whilst debugging another issue.

https://github.com/jellyfin/jellyfin-media-player/blob/e249fe58a06ce0621a80682b4d28d7458a625349/native/nativeshell.js#L63

The client above transmits [ ] as the value of ContainerProfiles gets parsed a Null when it should be Array.Empty().

image

BaronGreenback commented 3 years ago

@crobibero: It looks like MVC is interpretting [ ] as null, and breaking the nullable design. Is a generic array IModelBinder the way to go?

stale[bot] commented 3 years ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments. If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label. This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

HybridSarcasm commented 1 year ago

This has been open quite a while. Can this be re-produced with the current build? If so, please update the bug report details. Thanks!