jellyfin / jellyfin-plugin-dlna

GNU General Public License v3.0
23 stars 13 forks source link

DLNA PopcornHour profile is missing identification #14

Open BaronGreenback opened 3 years ago

BaronGreenback commented 3 years ago

Profiles are identified by the Indentification property. This one doesn't have one, meaning it's just eating resources as it will never be used.

https://github.com/jellyfin/jellyfin/blob/master/Emby.Dlna/Profiles/Xml/Popcorn%20Hour.xml

BaronGreenback commented 3 years ago

It's not there in 10.1, so don't know when it was removed.

From googling - looks like this could work.

    Manufacturer:Syabas Technology Inc.
    ModelDescription:Network Media Tank
BaronGreenback commented 3 years ago

Also the IgnoreTranscodeByteRangeRequests and TimelineOffsetSeconds are defined in the device profiles but never referenced. (TimelineOffsetSeconds has assigned values in the profiles)

SenorSmartyPants commented 3 years ago

I have a popcorn hour and am willing to test this. Haven't built JF before, just been using docker images.

HybridSarcasm commented 1 year ago

This has been open quite a while. Can this be re-produced with the current build? If so, please update the bug report details. Thanks!