jellyfin / jellyfin-plugin-kodisyncqueue

https://jellyfin.org
GNU General Public License v2.0
44 stars 13 forks source link

[Feature request] Add an include filter option #44

Open mcarlton00 opened 3 years ago

mcarlton00 commented 3 years ago

The current GetItems Endpoint accepts a filter option, however it's an opt out by media type. This can lead to extra slow syncs when a user has two libraries of the same type, but only has one synced to Kodi. In the current implementation, we would receive updates for both libraries and have to sort through them locally.

In a perfect world, I'd also like to change the API response to have full items. Currently, we get a list of item IDs, but then in order to process them locally in Kodi we have to make a separate request back to the server for each item. It would be far more efficient if we could retrieve a list of all the updated items at one time. If we go this route, I think we should probably make a new endpoint that returns the full items instead of changing the existing one. Otherwise, it's going to be a pretty big change with potential to break some/most setups.

crobibero commented 3 years ago

Need to ensure these properties are returned https://github.com/jellyfin/jellyfin-kodi/blob/master/jellyfin_kodi/objects/movies.py#L54-L96

mcarlton00 commented 3 years ago

Linked issue from the Kodi repo seems to indicate that the existing plugin logic is marking things as changed when we might not care about them. Probably should be it's own issue, but since it's all part of the same overall sync issues discussion it's worth mentioning here.

brando56894 commented 2 years ago

Any updates on this? Myself and various other users are still getting large library updates in Kodi.