search

jellyfin / jellyfin-plugin-nextpvr

https://jellyfin.org
MIT License
25 stars 9 forks source link

Remove extra logging #13

Closed emveepee closed 3 years ago

emveepee commented 3 years ago

During conversion PR some logging messages were added to release build which should not have been included

emveepee commented 3 years ago

@oddstr13 @crobibero Can this please be part of the 10.70 release. The changes made to PR 12 will add unnecessary log information and could be spammy.

Also what is the recommended method for dealing with the file/assembly minor version number.

crobibero commented 3 years ago

We only update the major version number, but in this case the plugin hasn't been released so no need to update it. IMO the debug logs should stay included so they don't need to be re-added in future updates

emveepee commented 3 years ago

We only update the major version number, but in this case the plugin hasn't been released so no need to update it. IMO the debug logs should stay included so they don't need to be re-added in future updates

I basically removed logging of information that I added for tracing during the conversion not for debugging. In my original submit they were not going to logger the were System.Diagnostics messages. These should have been removed in PR 12 not changed to logger output.

If there is a review in the future it will be to changes some logs from system to plugin specific debug logging. I haven't seen enough user logs to know what belongs were.