search

jellyfin / jellyfin-plugin-nextpvr

https://jellyfin.org
MIT License
25 stars 9 forks source link

More changes for 10.8 beta #39

Closed emveepee closed 2 years ago

emveepee commented 2 years ago

JSON changes in addon weren't implemented correctly, addon uses CamelCase style Deserialization. LiveTV call changed also. implemented according to TVHeadend logic (still not working)

crobibero commented 2 years ago

Can you please post logs with your latest changes? Something may need to be changed server-side- but I haven't had time to look into setting up NextPVR

emveepee commented 2 years ago

Can you please post logs with your latest changes? Something may need to be changed server-side- but I haven't had time to look into setting up NextPVR

@crobibero sure here you go https://pastebin.com/MGVS2zpw An actual user testing this says things are working ok.

crobibero commented 2 years ago

An actual user testing this says things are working ok.

Just to confirm, that means this PR is good to go?

emveepee commented 2 years ago

Just to confirm, that means this PR is good to go?

Is there anything I need to do to stop this log spam?

[2022-04-06 21:35:32.615 -04:00] [DBG] [25] Jellyfin.Api.Auth.CustomAuthenticationHandler: AuthenticationScheme: "CustomAuthentication" was not authenticated.

Also I don't know to actually have a proper version number displayed on the Add itself, does automation handle that?

crobibero commented 2 years ago

That log line is just saying that an unauthenticated request was made, no changes required.

Yes, the automation handles the version number updates.

emveepee commented 2 years ago

That log line is just saying that an unauthenticated request was made, no changes required.

Yes, the automation handles the version number updates.

Ok then it is ready to be merged when you are, I have no commits planned. I do find that log line really spammy, and I thought it was because of the addon, but maybe that is because I watch the log in real time, if that is normal fine. I also find I have to hit ctrl-f5 a lot to load pages especially on startup, but I guess that is how Jellyfin works since the addon doesn't control this. For a beta I am also surprised how many exceptions come up in the core logic, but again maybe I see them more because of the debugger breakpoints. Good luck with 10.8