search

jellyfin / jellyfin-plugin-opds

GNU General Public License v3.0
27 stars 4 forks source link

Feature Request: Feed should differentiate between different comic book formats #38

Closed rluetzner closed 5 months ago

rluetzner commented 5 months ago

I noticed that jellyfin-plugin-opds treats all comic book formats as application/x-cbr, but that is not correct. There are different file types, e.g. cbz, cb7, cbr. The file ending indicates which compression algorithm was used, although it can of course be misleading.

The examples above indicate the following compression algorithms:

This is a long introduction for the problem I observed: Rar is a proprietary algorithm and, while freely available, is usually not supported by FOSS eReader software (e.g. KOReader, Seeneva, ACV). So, if the feed claims that the comic book is in a proprietary format, most eReaders will not be able to download and display the books.

As I've said before, the file ending could be misleading, but as a first step, I would assume it is correct and assign the appropriate MIME type according to the file ending.

rluetzner commented 5 months ago

Hold on. I just had a look at the code and to me it seems like Jellyfin itself is providing the wrong MIME type. At least I couldn't find any explicit mention of x-cbr or cbr anywhere.

rluetzner commented 5 months ago

There's nothing to do. The bug is in a package dependency of the main Jellyfin project.