10.9 support - Githubissues

MBR-0001 commented 1 year ago

Also "modernized" the code:

Use file scoped namespaces, which is the reason why diff is big :(
Use is (not) null
~~Bumped .net version to 7~~ lol
Use PluginServiceRegistrator to register OpenSubtitleDownloader as an ISubtitleProvider because of https://github.com/jellyfin/jellyfin/pull/9191 (that's the only way I know how to do it)

Closes #143

crobibero commented 8 months ago

If you rebase on the unstable branch we can release this into the wild

crobibero commented 8 months ago

Also sorry for making other 10.9 changes, I just went through the list of plugins to make them buildable

MBR-0001 commented 8 months ago

I had to do the following modifications to csproj for it to build:

<ItemGroup>
    <Reference Include="blah/jellyfin/MediaBrowser.Common/bin/Debug/net8.0/MediaBrowser.Common.dll" />
    <Reference Include="blah/jellyfin/MediaBrowser.Controller/bin/Debug/net8.0/MediaBrowser.Controller.dll" />
    <Reference Include="blah/jellyfin/MediaBrowser.Model/bin/Debug/net8.0/MediaBrowser.Model.dll" />
  </ItemGroup>

original is:

<PackageReference Include="Jellyfin.Common" Version="10.*-*" />
<PackageReference Include="Jellyfin.Controller" Version="10.*-*" />

CI is not running so I'm not sure if this actually builds with unchanged csproj

jellyfin / jellyfin-plugin-opensubtitles

10.9 support #115