search

jellyfin / jellyfin-plugin-opensubtitles

https://jellyfin.org
GNU General Public License v3.0
131 stars 27 forks source link

fix policy #138

Closed Ch1nkara closed 8 months ago

Ch1nkara commented 1 year ago

fix policy name to match what's been accepted in the following PR: https://github.com/jellyfin/jellyfin/pull/10410

crobibero commented 1 year ago

Thank you for the change. This will be merged when 10.9 is released.

MBR-0001 commented 1 year ago

That controller is used for configuring the opensubtitles credentials in the plugin settings page, from what I understood the linked PR allows users to search and download the subtitles, but the configuration of the plugin itself is still restricted to the administrator?

Or did I get it wrong?

Ch1nkara commented 1 year ago

Indeed, from the UI a user can't access the plugin configuration page, even with the "subtitles management" rights. Currently, using Policy = Policies.RequiresElevation instead of Policy = "SubtitleManagement" could also work.

My opinion is that it's clearer to use the SubtitleManagement. Moreover, since we allow the user to use the opensubtitle plugin, it makes sense to let him also edit the credentials (not possible yet via jellyfin-web but might be implemented in the futur ?)