jellyfin / jellyfin-plugin-opensubtitles

https://jellyfin.org
GNU General Public License v3.0
131 stars 27 forks source link

language settings #151

Closed erlendoyen closed 2 months ago

erlendoyen commented 2 months ago

Hi

i have attempted to change all settings related to subtitle language to English every where in jellyfin

but from the logfile, the plugin still attempts to download unsupported language, where is this setting stored?

System.NotSupportedException: Language 'nb' is not supported
   at Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader.GetLanguage(String language, CancellationToken cancellationToken)
   at Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader.Search(SubtitleSearchRequest request, CancellationToken cancellationToken)
   at MediaBrowser.Providers.Subtitles.SubtitleManager.SearchSubtitles(SubtitleSearchRequest request, CancellationToken cancellationToken)
[2024-09-19 00:21:42.523 +02:00] [ERR] [47] MediaBrowser.Providers.Subtitles.SubtitleManager: Error downloading subtitles from "Open Subtitles"
System.NotSupportedException: Language 'nb' is not supported
crobibero commented 2 months ago

Have you also changed the language under Library -> Subtitle Downloads -> Download languages?

erlendoyen commented 2 months ago

Yes I have.

Is this message generated for all files individually? In that case is it possible to log what files the errors are logged for.

I know that open subtitles got files for some recently added files, but the subs are not downloaded

MBR-0001 commented 2 months ago

Are you sure that the "Norwegian Bokmål" language is not checked by accident? "nb" is the code for it

Not sure how else this could happen

erlendoyen commented 2 months ago

I will check again, but is this message generated for every file it can't download subs for?, that would give a pointer ot what's going on.

Is it also possible to log why isn't downloading subs for other files?

erlendoyen commented 2 months ago

turns out that it was still selected for some libraries, it would be nice to output the library or file names in the log.