Fixes, language improvements, code cleanup & error logging

MBR-0001 commented 2 years ago

Changes:

If the request fails and the response body is empty X-Reason header will be used in error logs (if it exists)
Replaced tuples with HttpResponse class
If JSON parsing fails the status code and the context of the request will be logged (which search params were used or file id of the subtitle when downloading)
Fixed pagination in SearchSubtitlesAsync
Requests for subtitles in unsupported languages are now dropped and languages are now properly formatted ~(not yet, waiting for response from opensubtitles)~
Fixed searching by providing query param

~EDIT: also waiting for response regarding BadRequest during subtitle fetching~ Fixes #65, fixes #66

crobibero commented 2 years ago

Looks like you’re re-adding existing commits, I recommend creating a new branch based off of jellyfin/master to ensure clean history

MBR-0001 commented 2 years ago

Looks like you’re re-adding existing commits, I recommend creating a new branch based off of jellyfin/master to ensure clean history

Yeah I just noticed that, I messed up when merging stuff

MBR-0001 commented 2 years ago

@crobibero ready for review

h1dden-da3m0n commented 2 years ago

thank you for your contribution MBR!

jellyfin / jellyfin-plugin-opensubtitles