jellyfin / jellyfin-plugin-playbackreporting

Playback Statistics Plugin for Jellyfin
https://jellyfin.org
GNU General Public License v3.0
67 stars 25 forks source link

Tidied up the interface to be consistent and easier to interact. #13

Closed AliMickey closed 4 years ago

AliMickey commented 4 years ago
AliMickey commented 4 years ago

Updated the versioning, just a question since its my first time.

Would it not be better to have a versioning system of 4.X.X with 5, 6, 7 being major changes similar to how other projects are done?

JustAMan commented 4 years ago

Would it not be better to have a versioning system of 4.X.X with 5, 6, 7 being major changes similar to how other projects are done?

We do so for main project, but we deemed plugins releases to be rather simple and not very frequent so decided to go with a very simple versioning scheme.

JustAMan commented 4 years ago

cc @jellyfin/backend

AliMickey commented 4 years ago

@dmitrylyzo i reverted your changes on user_playback_report.js, having an all option doesnt make sense as shown in the comment.

im probably not doing this thing right so sorry again, first time using git.

dmitrylyzo commented 4 years ago

As alternative (to minimize parseInt count).

var days = parseInt(weeks.value) * 7;

// Need to implement a better method to select all data instead of 18250 days = 50 years. 
if (days < 0) days = 18250;

Didn't test.

AliMickey commented 4 years ago

As alternative (to minimize parseInt count).

var days = parseInt(weeks.value) * 7;

// Need to implement a better method to select all data instead of 18250 days = 50 years. 
if (days < 0) days = 18250;

Didn't test.

Done, though i made it == -7 to have it stricter.

thanks

dmitrylyzo commented 4 years ago

@crobibero Did you have the same (bottom axis labels) for "unlimited" query? chart I did it in hacky way - set weeks to 2700

crobibero commented 4 years ago

@crobibero Did you have the same (bottom axis labels) for "unlimited" query? chart I did it in hacky way - set weeks to 2700

Yeah, the charting library will write the entire axis unless it's told to skip (https://www.chartjs.org/docs/latest/axes/cartesian/#tick-configuration)

If we find that the axis is getting out of hand axis.ticks.autoSkip should be set.