Closed AliMickey closed 4 years ago
Updated the versioning, just a question since its my first time.
Would it not be better to have a versioning system of 4.X.X with 5, 6, 7 being major changes similar to how other projects are done?
Would it not be better to have a versioning system of 4.X.X with 5, 6, 7 being major changes similar to how other projects are done?
We do so for main project, but we deemed plugins releases to be rather simple and not very frequent so decided to go with a very simple versioning scheme.
cc @jellyfin/backend
@dmitrylyzo i reverted your changes on user_playback_report.js, having an all option doesnt make sense as shown in the comment.
im probably not doing this thing right so sorry again, first time using git.
As alternative (to minimize parseInt
count).
var days = parseInt(weeks.value) * 7;
// Need to implement a better method to select all data instead of 18250 days = 50 years.
if (days < 0) days = 18250;
Didn't test.
As alternative (to minimize
parseInt
count).var days = parseInt(weeks.value) * 7; // Need to implement a better method to select all data instead of 18250 days = 50 years. if (days < 0) days = 18250;
Didn't test.
Done, though i made it == -7 to have it stricter.
thanks
@crobibero Did you have the same (bottom axis labels) for "unlimited" query? I did it in hacky way - set weeks to 2700
@crobibero Did you have the same (bottom axis labels) for "unlimited" query? I did it in hacky way - set weeks to 2700
Yeah, the charting library will write the entire axis unless it's told to skip (https://www.chartjs.org/docs/latest/axes/cartesian/#tick-configuration)
If we find that the axis is getting out of hand axis.ticks.autoSkip
should be set.
Added a semicolon after "weeks" to make it consistent with other variables.
Added extra spacing around cells to enable easier interaction and make it look nicer.
Fixed spelling of "re-imported"
Added dashes to improve readability.
Centered all graphs on the page.
Added an 'All' option to the week selection.