search

jellyfin / jellyfin-plugin-subtitleextract

GNU General Public License v3.0
31 stars 9 forks source link

Broken Image for Subtitle Extract #11

Closed Middlepepper closed 9 months ago

Middlepepper commented 1 year ago

Overview

When looking at the plugin in the Catalog It will not show a Icon or the default icon in jellyfin

image

Steps to reproduce

  1. Open Catalog
  2. View Plugin
GolDNenex commented 11 months ago

https://github.com/jellyfin/jellyfin-ux/pull/55

Middlepepper commented 9 months ago

Thanks for the update GolDNenex, Looks like it all fixed. Edit: Whoops spoke to soon. image

To provide some context it look like the

https://repo.jellyfin.org/releases/plugin/images/ has not been updated since 05-Dec-2021.

It might be better to update the meta.json from the out of date repo.jellyfin.org to the Github repository. ( "imageUrl": "https://repo.jellyfin.org/releases/plugin/images/jellyfin-plugin-subtitleextract.png") ( "imageUrl": "https://raw.githubusercontent.com/jellyfin/jellyfin-ux/master/plugins/repository/jellyfin-plugin-subtitleextract.png") Or host it within the repo itself like some other plugins do (Fintube or Newletter)

Middlepepper commented 9 months ago

So with a little more work I found you can have the image bundled locally which should solve this issue.

  1. adding a image.png to the repo that will automatically get detected.
  2. Setting the image: "" value within the build.yaml

https://github.com/oddstr13/jellyfin-plugin-repository-manager/blob/master/Metadata.md

crobibero commented 9 months ago

I haven't gotten around to updating the repo... I'll put it on my list of things to do. This has been low priority since it doesn't really negatively impact anything.

crobibero commented 9 months ago

The repo server has been updated