search

jellyfin / jellyfin-plugin-subtitleextract

GNU General Public License v3.0
31 stars 9 forks source link

Allow for subtitles to be extracted for new media #14

Closed Kakoluz closed 10 months ago

Kakoluz commented 10 months ago

Implementing this would allow subtitles to always be external, wich would make the need of transcoding due to slow loading subtitles gone even if the video has just been added.

Its implemented using a custom metadata provider that calls for the same code as the task did.

Task works as always, but the provider doesnt seem to be loading. its my frist time touching jellyfin, so maybe registering the provider is needed, but after looking for a lot of examples can't find anything related.

It should work after finding why it doesn't load, at leats it doesn't on my test server while doing library scans as it should.

MrMarble commented 10 months ago

Does this change add the option to manually extract the subtitles of a selected media? This alone is very useful specially for large libraries, It takes days to complete the first extraction, so ignoring the existing media is a necessity, adding the option to extract the subtitles for a desired media manually would also be quite nice

Hope is released soon!

Kakoluz commented 10 months ago

Does this change add the option to manually extract the subtitles of a selected media? This alone is very useful specially for large libraries, It takes days to complete the first extraction, so ignoring the existing media is a necessity, adding the option to extract the subtitles for a desired media manually would also be quite nice

Hope is released soon!

It does not allow for extraction of a single media. It isn't really that hard to implement, but in my opinion it would be a different feature, so it should go on its own PR as it might need some discussion about the best method of implementing it.