search

jellyfin / jellyfin-plugin-subtitleextract

GNU General Public License v3.0
31 stars 9 forks source link

Other subtitles types #20

Closed Nodiink closed 1 month ago

Nodiink commented 5 months ago

This plugin only support extraction of SRT and SSA/ASS sub types. Why are other subs (vtt, idx, pgs, ...) excluded? Is there no benefit for Jellyfin to have these subtitles extracted?

crobibero commented 5 months ago

It's been a while since this was originally written, but I don't remember why I filtered by those formats.

I don't have the ability to test with the formats you mentioned, so someone else would have to create the PR with proof that it works

thornbill commented 5 months ago

I doubt image based formats like pgs would be possible?

Nodiink commented 5 months ago

I doubt image based formats like pgs would be possible?

All subtitle have a file format, even image based ones, like PGS (.sup) and VobSub (.idx)

It's been a while since this was originally written, but I don't remember why I filtered by those formats.

My idea is that every subtitle should be extracted, whether the player supports that subtitle as is or not should not be an issue with this plugin.

I don't have the ability to test with the formats you mentioned, so someone else would have to create the PR with proof that it works

I can compile and test a version that extracts them all, but I don't know how to verify whether the extracted subtitle is taken or not by the player.

thornbill commented 5 months ago

Oh doh right this just extracts them as is and doesn't convert to a different format. 🤦‍♂️ Just ignore me lol.

crobibero commented 1 month ago

This should be fixed in v4 of the plugin