jellyfin / jellyfin-plugin-tmdbboxsets

https://jellyfin.org
MIT License
83 stars 18 forks source link

Plug-in ignoring "minimum number of movies" setting. #81

Open tompwtompw opened 2 months ago

tompwtompw commented 2 months ago

Based on this forum thread

I have the TMDb Box Sets plug-in, with "minimum number of movies" set to three. For collections with 3 or more movies, everything works fine. The issue is that is creates collections with just 2 movies (despite the setting), and then those collections don't have images or metadata. It's like the plugin creates the folder in\Jellyfin\Server\data\collections\ (which JellyFun server then picks up on), but then doesn't do anything with it because it has too few items.

Example of the relevant log entries (after I added The Bourne Identity and later The Bourne Supremacy): [2024-07-17 10:16:51.368 -04:00] [INF] [8] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Minimum number of movies is 3, but there is/are only 1: "The Bourne Identity" --> No collection added (as expected) [2024-07-17 23:09:44.684 -04:00] [INF] [8] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Minimum number of movies is 3, but there is/are only 2: "The Bourne Identity, The Bourne Supremacy" --> Collection added, with no images (not as expected) [2024-07-17 23:12:35.345 -04:00] [INF] [63] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Minimum number of movies is 3, but there is/are only 2: "The Bourne Identity, The Bourne Supremacy" [2024-07-17 23:22:12.918 -04:00] [INF] [45] Jellyfin.Plugin.TMDbBoxSets.ScheduledTasks.RefreshLibraryTask: Starting TMDbBoxSets refresh library task [2024-07-17 23:22:14.758 -04:00] [INF] [45] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Found 67 TMDb collection(s) across all movies .... [2024-07-17 23:22:14.813 -04:00] [INF] [45] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Minimum number of movies is 3, but there is/are only 2: "The Bourne Identity, The Bourne Supremacy" [2024-07-17 23:22:15.400 -04:00] [INF] [45] Jellyfin.Plugin.TMDbBoxSets.ScheduledTasks.RefreshLibraryTask: TMDbBoxSets refresh library task finished [2024-07-17 23:22:15.410 -04:00] [INF] [45] Emby.Server.Implementations.ScheduledTasks.TaskManager: "Scan library for new box sets" Completed after 0 minute(s) and 2 seconds

Separately, I opened up Jellyfin.Plugin.TMDbBoxSets.dll in Notepad, and found the following text:

If I'm reading that right, then it's falling back to 2 because something somewhere isn't (correctly) pulling the value from the configuration page.

I'm running Jellyfin v10.9.6 on a Windows 7 Pro PC (SP1, 64-bit); Jelly BoxSets version 11.0.0.

lldsolitude commented 2 months ago

Same issue here.

Equinox3141 commented 1 month ago

same issue here