search

jellyfin / jellyfin-plugin-tmdbboxsets

https://jellyfin.org
MIT License
86 stars 20 forks source link

feat filter by library #91

Open Urogna opened 1 month ago

Urogna commented 1 month ago

83

I needed this issue for myself too.

This is my first time contributing to jellyfin. Please review thoroughly, and give a bit of context for stuff I may have gotten wrong for future possible contributions.

For PluginConfiguration.LibraryIdsCSV I went with csv string instead of List or Collection because the linter was causing issues, and parsing the list from the web was causing issues... Might have missed something there 🤔I'm really not too familiar with C#

With this feature simply activating the plugin won't do anything since libraries are deactivated by default. For me this is correct behaviour since one might not want to scan the library before configuring it. But I'm open for just scanning the whole library if no specific library has been selected.

In my case I had to add a NuGet.config file to build the plugin, otherwise the jellyfin package wasn't beeing recognized. I thought I'd leave it in since it may not hurt.

thanks for the feedback

Urogna commented 1 month ago

Maybe for some additional context. I have multiple languages set up, and since 1 movie might be in present in multiple languages across all libraries, it would create collections for single movies, since the same movie was present twice.

Here the new config screen: image