search

jellyfin / jellyfin-plugin-trakt

https://jellyfin.org
MIT License
179 stars 32 forks source link

Added config parameter Don't remove items from trakt #196

Closed addamanth closed 1 year ago

addamanth commented 1 year ago

Added option not to remove items from trakt.tv collection in case they removed from local collection

crobibero commented 1 year ago

Just a preference, but I would prefer the feature be called RemoveFromTrakt, the double negation makes the code more difficult to read

addamanth commented 1 year ago

Just a preference, but I would prefer the feature be called RemoveFromTrakt, the double negation makes the code more difficult to read

Thank you for feedback. There are a couple of things behide this

  1. to be in line with other plugin options like 'Skip unwatched import from trakt.tv'. Probably the naming is not very good.
  2. to keep the current logic of collection synchronization and change it only by checking of new option