search

jellyfin / jellyfin-plugin-tvheadend

https://jellyfin.org
MIT License
32 stars 19 forks source link

Fix channel images #72

Open mdonoughe opened 9 months ago

mdonoughe commented 9 months ago

I was trying to get the Jellyfin app working on my TV and in the server logs I was seeing a lot of errors about objects being in the wrong state and not being able to parse URL host names. The invalid state messages are a Jellyfin bug where it throws the wrong type of exception when it fails to download an image. The URL host name problem turned out to be because my password contained special characters and they weren't being escaped when building URLs.

I changed my password to a simpler one but it still didn't work. Jellyfin wasn't sending the username and password from the URL. There are two problems here. First, it doesn't send basic authentication when credentials are provided in the URL and, second, Tvheadend by default doesn't accept basic authentication anymore. I made LiveTvService implement IDynamicImageProvider and it still doesn't work without telling Tvheadend to accept basic authentication, but now I have images loading and no errors are displayed when trying to watch a channel.

That doesn't seem like fixing some image load errors should have fixed video playback in the TV app, but it just worked.

mdonoughe commented 9 months ago

Well I deployed the new plugin onto my server and rebuilt the library and now I have channel images and there are no errors when I try to start the stream, but it still doesn't play so that must be something else.

crobibero commented 9 months ago

May not fix your actual issue... but fixing image loading is still great!

lionking102 commented 6 months ago

This is one of my biggest issues with tvheadend for jellyfin. Fixing the channel-images is aweseome, thank you! Hope this gets merged soon.