search

jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
449 stars 137 forks source link

Crashes in baserequest.brs #1062

Closed cewert closed 1 year ago

cewert commented 1 year ago

This bug was discovered via a crash log report on roku.com. Line 10 and 121 have been in the code forever. Line 56 may have been introduced by #115.

Software Versions Jellyfin Server Version: N/A Roku Client Version: 1.6.3

Describe the bug App occasionally crashes

Logs

Function apirequest(url As String) As Object; pkg:/source/api/baserequest.brs(56)
Function apirequest(url As String) As Object; pkg:/source/api/baserequest.brs(121)

The app is occasionally crashing when it encounters the lines of code above.

Additional context A BrightScript crashlog report was recently run on roku.com and this bug is causing the app to crash ~10 times a day. Logs are not provided. Just the function call and line number where the crash occurred.

Keep in mind these errors are coming from production so the line numbers should be compared to the v1.6.3 tag (or latest version of master. same thing) and not the latest version of unstable

cewert commented 1 year ago

Removing line 10 from the list. It hasn't caused a crash since v1.5.0