Closed cewert closed 11 months ago
We also have our vscode brightscript linter and CI ignoring all code found in a roku_modules
folder. This would be the only way of catching linting errors in the modules since there are no workflows enabled in the modules' repos themselves.
Is your feature request related to a problem? Please describe
Using roku modules instead of integrating the code directly creates several problems
MODULEALIAS_
. This makes the code slightly more difficult to read and write.npm install
to pull in all the necessary files for the app to worknpm install
without needing approval. This presents a potential security risk if the modules start pushing malicious code udpates. This one is fixable.I can't think of one reason why having these dependencies helps us. I know there's the potential to help people who want to use the NPM modules to build a roku app but there's no reason our app has to use or depend on them. They could and should be a separate thing IMO.
Describe the solution you'd like
Remove Roku module dependencies and integrate into code base directly. There are no downsides to doing this that I'm aware of.
Describe alternatives you've considered
Additional context
https://github.com/jellyfin/jellyfin-roku/issues/1112#issuecomment-1476853240