Deleting servers on serverselect view produces unexpected results

[cewert]

Software Versions

• Jellyfin Server Version: demo stable
• Roku Client Version: 1.6.4

Describe the bug

There's a few:

• Hitting the options key shows the delete saved server option no matter what - even when highlighting the URL textbox and the submit button
  • I only had 1 saved server, the demo server, and that is what was deleted when i pressed options on the submit button but what happens if I have two saved servers? Will it always delete the top one or?
• If you have one server saved then delete it, the view looses focus with no way to get it back
• The available_users registry key also saves the users current server so if the user is currently logged in to the saved server this info isn't purged like it should be

Expected behavior

• The options menu only gets displayed when hovering a saved server
• Focus is restored to the URL textbox instead of being lost
• All registry data for the saved server is purged

Connection Information

• Is server local or remote? remote
• Is server connection HTTP or HTTPS? HTTPS

Additional context

Introduced in #512

The data we are saving in the registry for each saved server seems excessive

{"serverlist":[{
    "baseurl":"https://demo.jellyfin.org/stable",
    "iconheight":120,
    "iconurl":"pkg:/images/logo-icon120.jpg",
    "iconwidth":120,
    "name":"Stable Demo (Saved)",
    "password":"",
    "username":"demo"
}]}

The available_users registry key saves the same information minus the server "name" :

[{
  "id":"a076a5bfc9034f379f588XXXXXXXXX",
  "server":"https://demo.jellyfin.org/stable",
  "username":"demo"
}]

[cewert]

Oh and anyone who wants to test the server select view I HIGHLY recommend using RALE that way you can repopulate the saved_server registry setting by copy/pasting into RALE instead of manually doing it with the remote 😄

Here's the payload for the demo server

{"serverlist":[{"baseurl":"https://demo.jellyfin.org/stable","iconheight":120,"iconurl":"pkg:/images/logo-icon120.jpg","iconwidth":120,"name":"Stable Demo (Saved)","password":"","username":"demo"}]}