jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
450 stars 141 forks source link

Don't modify roku system setting for subtitles #1259

Open cewert opened 1 year ago

cewert commented 1 year ago

After thinking about this, I don't think we should ever be modifying the roku system setting for subtitles but maybe I'm missing something. Feedback would be appreciated. I think we should try and respect them as best as we can but we shouldn't be changing them based on what the user does inside our app. For two reasons:

Is your feature request related to a problem? Please describe

Selecting subtitles from the subtitle popup during playback (down) changes the roku system setting for subtitles as follows:

As for On replay:

Describe the solution you'd like

Don't modify the system setting at all. If the roku system setting is:

Describe alternatives you've considered

Completely ignoring the roku system setting but that doesn't make sense to me. We'd probably need to add user settings that do the same thing.

Additional context

I'm using the new global video player to test

Alliyance commented 1 year ago

Glad someone is looking into that issue:) Thanks