After thinking about this, I don't think we should ever be modifying the roku system setting for subtitles but maybe I'm missing something. Feedback would be appreciated. I think we should try and respect them as best as we can but we shouldn't be changing them based on what the user does inside our app. For two reasons:
The user can easily change their system setting using the star(*) key during video playback
Our app is meant to support multiple users which may have different preferences regarding subtitles. Users can use the jellyfin web client user settings to set their preferences allowing each user to fully customize their environment without affecting each other.
Is your feature request related to a problem? Please describe
Selecting subtitles from the subtitle popup during playback (down) changes the roku system setting for subtitles as follows:
None - Sets system setting to Off (even if the popup was already set to none. see here)
any selection - Sets system setting to On always
As for On replay:
Subtitles are correctly shown when using the replay button but the subtitles don't go away after 15sec (or however long the replay button rewinds)
There is no way to select and use subtitles in the roku app and retain the system setting.
Describe the solution you'd like
Don't modify the system setting at all. If the roku system setting is:
Off - Never automatically load subtitles unless they are "forced subtitles". Don't change system setting when loading "forced subtitles" (see #1218) or even "normal" subtitles.
On Always - Attempt to load subtitles every time the user watches a video in the roku app but use the jellyfin default language instead of the system setting (to accommodate multiple jellyfin users who may have different language preferences). If the user turns off subtitles for a video do not modify system setting.
On replay - Auto load "forced" subtitles and also attempt to load subtitles when using the replay button - use the jellyfin default language. Don't modify system setting.
Describe alternatives you've considered
Completely ignoring the roku system setting but that doesn't make sense to me. We'd probably need to add user settings that do the same thing.
After thinking about this, I don't think we should ever be modifying the roku system setting for subtitles but maybe I'm missing something. Feedback would be appreciated. I think we should try and respect them as best as we can but we shouldn't be changing them based on what the user does inside our app. For two reasons:
Is your feature request related to a problem? Please describe
Selecting subtitles from the subtitle popup during playback (down) changes the roku system setting for subtitles as follows:
None
- Sets system setting toOff
(even if the popup was already set tonone
. see here)any selection
- Sets system setting toOn always
As for
On replay
:Describe the solution you'd like
Don't modify the system setting at all. If the roku system setting is:
Off
- Never automatically load subtitles unless they are "forced subtitles". Don't change system setting when loading "forced subtitles" (see #1218) or even "normal" subtitles.On Always
- Attempt to load subtitles every time the user watches a video in the roku app but use the jellyfin default language instead of the system setting (to accommodate multiple jellyfin users who may have different language preferences). If the user turns off subtitles for a video do not modify system setting.On replay
- Auto load "forced" subtitles and also attempt to load subtitles when using the replay button - use the jellyfin default language. Don't modify system setting.Describe alternatives you've considered
Completely ignoring the roku system setting but that doesn't make sense to me. We'd probably need to add user settings that do the same thing.
Additional context
I'm using the new global video player to test