search

jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
439 stars 133 forks source link

Thrown back to play screen with no error when subtitle would occur with directplay and PGS subtitles and the subtitles are off #1569

Open sarnex opened 9 months ago

sarnex commented 9 months ago

Software Versions

Describe the bug

This is a really weird one. If I play a video that directplays and the video has PGS subtitles and the subtitles are off!!! i get thrown back to the play screen right before a subtitle would appear if they were enabled without an error message. this does not happen if I turn on the subtitles, and does not happen if I force it to transcode for another reason. The web player works fine, so it seems to be a roku client issue. see the video of the issue here: https://www.youtube.com/watch?v=No2NBoSAqR8 The problem happens at 0:35. Just so say again so it's clear, the issue only happens with subtitles OFF. If they are on it works fine. The problem happens with other videos meeting those conditions too, not just the one in the youtube video. A really weird thing is that if I use mkvtoolnix to remux the original mkv file with all the same tracks including the subtitle tracks, that works fine. So it seems it's something with the mkv file, but it plays fine both on the web player and locally on mpv outside of roku.

How To Reproduce

  1. Play video that has PGS subs and directplays and make sure subs are off
  2. Wait for a time in the video to occur where there would be a subtitle if they were on
  3. You will get thrown to the play screen

Expected behavior

I expect it to play the video without subtitles

Logs

telnet log from unstable when subs are off and the problem happens: https://gist.github.com/sarnex/3fd6dda3587384346265d1f2f7da76d9

jellyfin log from when subs are off and the problem happens: https://gist.github.com/sarnex/d7f028a71de6adf007892bca7b1f07a9

jellyfin and ffmpeg log when subs are on and the problem does not happen (it transcodes): https://gist.github.com/sarnex/2e0bb3c0833a05a2c60c62aae0e153f3

Screenshots

Video: https://www.youtube.com/watch?v=No2NBoSAqR8

Connection Information

1hitsong commented 9 months ago

Thank you for the detailed bug report! We're looking into the subtitles issues.

FYI for anyone experiencing this issue: We can't update the app till January 2nd due to the roku holiday blackout. If we're able to fix it before then and push an update release on the 2nd, the app would hit Roku devices a few days later.

Unfortunately, the only workaround until then is to sideload v1.6.6.

You can find the app here: https://github.com/jellyfin/jellyfin-roku/releases/tag/v1.6.6

You can find instructions here: https://github.com/jellyfin/jellyfin-roku/discussions/897

sarnex commented 9 months ago

@1hitsong Thanks for the response! Sorry if I misunderstood your comment, but this issue is still reproducible in both v1.6.6 and the current development branch as of https://github.com/jellyfin/jellyfin-roku/commit/c9cf7007e454699873bc1d028733a3c27aba82e4, so sideloading v1.6.6 would not fix this issue.