search

jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
441 stars 134 forks source link

Use the main web clients home screen failing. #1578

Closed p37307 closed 2 months ago

p37307 commented 9 months ago

Software Versions

Describe the bug

Changing the settings to use the main web clients home view arrangement is partially failing.

How To Reproduce

  1. Open Jellyfin Roku 2.0.0, press *, settings, user interface, general, use web clients home screen, enable.
  2. Restart Jellyfin
  3. Web clients home screen library folder order is respected in the top "My Media" but the order below in the "Latest Media" "next up/new" library folder arrangements are ignored.

Expected behavior

Home screen library lineup should match Jellyfin's web clients in the My Media row, which it does, as well as the remaining Latest Media rows below. Favorites are delegated to the bottom, movies to the top.

Logs

Log after removing roku from devices in the webclient, loggin in Jellyfin Roku, setting the web client view setting, exiting Jellyfin Roku opening Jellyfin Roku. Nothing really shows up that I can see. ` 2023-12-13 19:29:26.346 -05:00] [ERR] [7] Jellyfin.Server.Implementations.Users.UserManager: Error authenticating with provider "Default" MediaBrowser.Controller.Authentication.AuthenticationException: Invalid username or password at Jellyfin.Server.Implementations.Users.DefaultAuthenticationProvider.Authenticate(String username, String password, User resolvedUser) at Jellyfin.Server.Implementations.Users.UserManager.AuthenticateWithProvider(IAuthenticationProvider provider, String username, String password, User resolvedUser) [2023-12-13 19:29:26.383 -05:00] [INF] [7] Jellyfin.Server.Implementations.Users.UserManager: Authentication request for "tv" has been denied (IP: "192.168.0.182"). [2023-12-13 19:29:26.403 -05:00] [ERR] [7] Jellyfin.Server.Middleware.ExceptionMiddleware: Error processing request: "Invalid username or password entered". URL "POST" "/Users/AuthenticateByName". [2023-12-13 19:29:39.973 -05:00] [INF] [7] Jellyfin.Server.Implementations.Users.UserManager: Authentication request for "tv" has succeeded. [2023-12-13 19:29:39.976 -05:00] [INF] [7] Emby.Server.Implementations.Session.SessionManager: Current/Max sessions for user "tv": 0/0 [2023-12-13 19:29:39.991 -05:00] [INF] [7] Emby.Server.Implementations.Session.SessionManager: Creating new access token for user 2dbXXXXX-dxXXXb-4394-a231-48XXXXXXX2

`

Screenshots

My Media, (libraries in the correct web client order) Continue Watching and Next Up rows are in the correct places. Then random library row loads, then Movies, regardless of where set in Web Client and the remaining libraries.

Image: Left, web client as the library order should and does appear. Right, Jellyfin Roku 2.0.0 order. Sometimes in Roku, between Next Up and Movies, a random library row is there. sidebyside

Connection Information

Additional context

This happens on three different Roku's, all of different Roku models.

1hitsong commented 9 months ago

My first thought is we've created a race condition in the Latest In load tasks. The order the tasks are completing is the order the rows are being set.

cewert commented 9 months ago

In 1.6.6, we were creating temporary "latest in" rows for each library once we had the "my media" data. Then later when we got data for each "latest in" row, we found the row by title and inserted the data. https://github.com/jellyfin/jellyfin-roku/blob/v1.6.6/components/home/HomeRows.brs#L96

I'm betting we stopped making temporary rows but I haven't looked into how we are doing things now.

Alliyance commented 8 months ago

Same issue with version 2.0.0 and 2.0.1 Next up and Continuted watching are in the right position. Latest movies and Latest series keeps changing. Sometimes, movies will be on top and some days series will be on top.

But thank you for fixing the subtitles with the new version 2.0.1 :):):)

p37307 commented 8 months ago

Same issue with version 2.0.0 and 2.0.1 Next up and Continuted watching are in the right position. Latest movies and Latest series keeps changing. Sometimes, movies will be on top and some days series will be on top.

Can confirm, still an issue after 2.0.1.

Will add, Favorites are on the bottom for both versions. Haven't sideloaded any testing versions lately.

1hitsong commented 8 months ago

We haven't worked on a bug fix for this yet.

You can see the list of updates in the What's New popup on your Roku, or in the release notes: https://github.com/jellyfin/jellyfin-roku/releases/tag/v2.0.1

Alliyance commented 8 months ago

Sorry my fault, I haven't check the fix list. 🥴