jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
419 stars 128 forks source link

Music Playback: Make Previous/Next Track ignore Loop Once without disabling it #1615

Open 1hitsong opened 6 months ago

1hitsong commented 6 months ago

During music playback, make it so clicking previous or next song changes the playing song, but doesn't disable Loop Once if it's enabled.

Additional context

Enhancement idea comes from Mastodon: https://social.linux.pizza/@steffo@uno.starshard.studio/111694903495156475

image

Steffo99 commented 6 months ago

Heya! Thanks for opening an issue for me! :smile:

What happens now

(Haven't tested on Roku, just on the web interface and Android client, so forgive me if this is inaccurate...)

Currently, when Loop Once is enabled and the Next Track button is pressed, Jellyfin restarts the playback of the current track, which isn't very useful, as the functionality is already covered by pressing Previous Track once.

What should ideally happen

Other media players have one of the following two behaviours when this happens:

Personally, I find the second option to be the most useful, since media controls on headphones and keyboards don't usually have a Loop button and so would then require me to reopen the player to re-enable it manually.

I know that some other people would rather have the first one though, so ideally the behaviour in this case should be configurable in the Playback settings (maybe even keeping the current one as an option in case somebody has grown used to it?).