search

jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
412 stars 129 forks source link

2.x No Longer Uses Device Nickname #1666

Open michaelcresswell opened 5 months ago

michaelcresswell commented 5 months ago

Software Versions

Describe the bug

Jellyfin 2.x no longer reports device nickname to the server

How To Reproduce

  1. Connect to a Jellyfin server with the Roku client
  2. Go to server Administration -> Dashboard
  3. Click Devices
  4. Observe the Roku device

Expected behavior

The device nickname is part of the device identifier

Screenshots

From the Admin Page:

2.0.2 image G000X seems to correspond to the Hardware ID of G109X

1.6.6 image Living Room TV (abbreviated in the screenshot) is the nickname shown on the Roku app

Connection Information

Additional context

The 1.6.6 client reports the nickname which makes it easier to indentify clients, especially when multiple clients have similar hardware.

It’s a minor regression but something I noticed in the dashboard.

krkc commented 5 months ago

This looks like the commit where the change was made:

https://github.com/jellyfin/jellyfin-roku/commit/d0bbd696f60089ec00fb2dd4eeb0d18285acd284

michaelcresswell commented 5 months ago

Interesting…feel free to close this as not a bug if that was intended, @cewert

cewert commented 5 months ago

@michaelcresswell yea the change was on purpose but I don't use a Roku TV. It appears my changes are only an improvement for roku devices and not roku TVs. I'll have to look into updating the auth header based on device type.

This is how the changes look for me:

roku-jellyfin-dash-change

michaelcresswell commented 5 months ago

Do you have nicknames setup for your devices? Just curious if that 1.6.6 valve was some auto-generated default name or if non-TVs are really that different.

(https://my.roku.com/dashboard -> My Devices -> Nickname; couldn’t find a way to do it locally)

cewert commented 5 months ago

Do you have nicknames setup for your devices?

I don't think so but this roku was setup using someone else's email so I could be wrong.