search

jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
442 stars 135 forks source link

Add View All for Next Up #1846

Closed jimdogx closed 2 months ago

jimdogx commented 2 months ago

Add "View All Next Up".

Changes

Adds a new "View All Next Up" on the Next Up home screen row. This adds parity to the web client and allows the user to see items that are Next Up that don't fit within the Roku's max column count or items that might be greater than 365 days old.

Issues

Fixes #1481

jellyfin-bot commented 2 months ago

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

jimdogx commented 2 months ago

Episodes without a widescreen image are in the shape of the folder icon when viewing the View All Next Up view. I sent you a screenshot on matrix

Do you know off the top of your head what the home screen does in this case? I was trying to make the "View All" page work exactly like the "Next Up" row on the home screen. And on my setup, they are all wide screen posters 😄

cewert commented 2 months ago

Do you know off the top of your head what the home screen does in this case? I was trying to make the "View All" page work exactly like the "Next Up" row on the home screen. And on my setup, they are all wide screen posters 😄

Home page uses scaleToZoom for the Poster node's loadDisplayMode property. https://developer.roku.com/en-ca/docs/references/scenegraph/renderable-nodes/poster.md#fields

jimdogx commented 2 months ago

Do you know off the top of your head what the home screen does in this case? I was trying to make the "View All" page work exactly like the "Next Up" row on the home screen. And on my setup, they are all wide screen posters 😄

Home page uses scaleToZoom for the Poster node's loadDisplayMode property. https://developer.roku.com/en-ca/docs/references/scenegraph/renderable-nodes/poster.md#fields

Took me all day to figure this one out... turns out it was the frigging "PosterMask" that was causing the clipping.

jimdogx commented 2 months ago

@cewert it occurred to me that making it smarter wouldn't be that hard after all. Plus I coded it so that it's an extra API call if (and only if) there really isn't anything to show in the Next Up home row. 👍

Ready for review again 😄

p37307 commented 2 months ago

Thank you for working on this. Will make using Roku app better with my Parkinsons. I won't have to go hunt for episodes that dropped off the list. I've been hoping for this for a long time! https://github.com/jellyfin/jellyfin-roku/issues/1481#event-13679835569