jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
443 stars 135 forks source link

crashes when clicking on movie library #599

Closed RVCU closed 2 years ago

RVCU commented 2 years ago

Describe the bug Click on movie from library and it flashes the movie page quickly before crashing. This seems to only happen for HEVC encoded movies, H264 can be selected and played fine App version is 1.4.12, building and installing the master branch seems to fix this. Server is fresh install of 10.7.7.

To Reproduce

  1. Go to Movies library
  2. Click on a HEVC encoded movie

Logs

                                                                                                                                                                                                           [38/513]
BrightScript Micro Debugger.                                                                                                                                                                                       
Enter any BrightScript statement, debug commands, or HELP.                                                                                                                                                         

Suspending threads...                                                                                                                                                                                              

Thread detached                                                                                                                                                                                                    

Thread detached                                                                                                                                                                                                    
Thread selected:  1*   ...nents/movies/MovieDetails.brs(105)   videos.push({ "Title": streams[i].Name, "Description": tr("V                                                                                        

Current Function:                                                                                                                                                                                                  
099:  sub SetUpVideoOptions(streams)                                                                                                                                                                               
100:                                                                                                                                                                                                               
101:      videos = []                                                                                                                                                                                              
102:                                                                                                                                                                                                               
103:      for i = 0 to streams.Count() - 1                                                                                                                                                                         
104:          if streams[i].VideoType = "VideoFile"                                                                                                                                                                
105:*             videos.push({ "Title": streams[i].Name, "Description": tr("Video"), "Selected": m.top.selectedVideoStreamId = streams[i].id, "StreamID": streams[i].id, "video_codec": streams[i].mediaStrea     
106:          end if                                                                                                                                                                                               
107:      end for                                                                                                                                                                                                  
108:                                                                                                                                                                                                               
109:      options = {}                                                                                                                                                                                             
Source Digest(s):                                                                                                                                                                                                  
pkg: dev 1.4.12 bbf3534ff54f03fa40d9b87a9dad6d5c Jellyfin                                                                                                                                                          

'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/movies/MovieDetails.brs(105)                                                          
Backtrace:                                                                                                                                                                                                         
#1  Function setupvideooptions(streams As Dynamic) As Void                                                                                                                                                         
   file/line: pkg:/components/movies/MovieDetails.brs(105)                                                                                                                                                         
#0  Function itemcontentchanged() As Void                                                                                                                                                                          
   file/line: pkg:/components/movies/MovieDetails.brs(94)                                                                                                                                                          
Local Variables:                                                                                                                                                                                                   
streams          roArray refcnt=2 count:1                                                                                                                                                                          
global           Interface:ifGlobal                                                                                                                                                                                
m                roAssociativeArray refcnt=3 count:8                                                                                                                                                               
videos           roArray refcnt=2 count:0                                                                                                                                                                          
i                Integer val:0 (&h0)                                                                                                                                                                               
options          <uninitialized>                                                                                                                                                                                   
Threads:                                            
ID    Location                                Source Code                                                
 0[u] ??                                            
 1*   ...nents/movies/MovieDetails.brs(105)   videos.push({ "Title": streams[i].Name, "Description": tr("V                                                                                                         
  *selected   [u]unattached(not debuggable)         

Additional context TCL roku tv

jimdogx commented 2 years ago

This line of code has been updated via PR #580 , which I think might also fix your issue if I'm understanding this comment correctly:

building and installing the master branch seems to fix this

Just to make sure I understand, when you run the current "master" version from GitHub, it no longer crashes, correct?

RVCU commented 2 years ago

Yep, building and installing master fixes this issue for me.

jimdogx commented 2 years ago

Yep, building and installing master fixes this issue for me.

That's good to know. Since that's the case, I think we can close this issue as it's already fixed and on its way soon with the next release 👍