Closed TwitchBronBron closed 2 years ago
I've wanted to do this before but wasn't sure the best way to go about it. I think your way of doing it makes a lot of sense using brightscript.debug.host
.
The comment warnings are a great idea and we would need to update the devguide.
The only downside I can see would be the risk of someone committing their roku IP and password to git on accident by editing the launch config manually. The warnings and devguide would obviously help with that.
I think making it easier for devs to help with roku outweighs that risk but that's my two cents. Curious to hear what everyone else thinks
There are a few nonstandard folders that need to be included in the launch.json files array which means it won't work out of the box. For that reason I'd advocate for removing the
.vscode
folder from .gitignore so we can include an "it works out of the box" launch.json, with some documentation around how to manually set the host and password in user settings instead. The defaults host and password are${promptForHost}
and${promptForPassword}
so that'll work out of the box. Then, in user settings, you can set these values to override the defaults without needing to edit the launch.json directly.we could even add comments warning the users NOT to edit launch.json directly. Something like this: