search

jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
450 stars 141 forks source link

Drop built in support for 720p and have Roku autoscale #70

Closed cewert closed 5 years ago

cewert commented 5 years ago

In the manifest file we have ui_resolutions=hd,fhd which is telling Roku we have two versions of the GUI, one for 1080p and and one for anything above 720p. Is this intentional? Is the app currently designed with this in mind?

When viewing the app on my 1080p screen (with 1080p selected in Roku settings) I noticed the GUI for the app doesn't look right (spacing off, missing buttons etc.). I then set up RALE and noticed that the app is forcing my resolution to 720p somehow?

I changed the manifest file to ui_resolutions=fhd , deployed, and now the app looks much better. I can actually see the little button for search on the main page, TV and Movie detail screens look better and I can see all the buttons!

I suggest we design for 1080p (fhd) and let Roku automatically scale the app down as needed like Roku recommends (see Recommended intended resolution and Autoscaling guidelines)

bisby commented 5 years ago

Nope. this was a complete misunderstanding of the manifest file. I thought we needed to specify which resolutions the app COULD run at, rather than what resolutions it was built for.

Autoscaling would be great, and would fix a ton of other issues, and also we could strip out a TON of poorly written code that was trying to be clever about scaling, thinking we were going to need to go percentage based ("bar is the left 10% of the screen", etc)

cewert commented 5 years ago

I was wondering what all the math was for hah I was too scared to touch the layout. Still trying to wrap my head around Brightscript

I'll change it real quick and send a PR