search

jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
451 stars 141 forks source link

Embedded SRT subtitle sync #950

Open rudism opened 1 year ago

rudism commented 1 year ago

Software Versions Jellyfin Server Version: 10.8.8 Roku Client Version: 1.6 build 2

Describe the bug Embedded SRT subtitles rarely sync up correctly, and the problem intensifies when resuming partially played media.

How To Reproduce

Play a movie or TV show with embedded SRT subtitles (all examples I have tried are HEVC Main 10, one of 480p, SDR 1080p, or HDR 4K with ac3 audio tracks in an mkv container) and turn the subtitle track on. Compare the timings of when the subtitles appear on screen to the same subtitles appearing when playing the same file directly using vlc, mpv, or the Jellyfin web interface--they may be close on the Roku but often off by up to a second or two.

Stop playing the media part way through--far enough that Jellyfin will offer the option to resume next time. Play the media again and resume, and turn subtitles back on. The subtitles will often now be offset by even more, sometimes up to 10 seconds or more late. Pausing, rewinding, fast forwarding, disabling and re-enabling the subtitle track all seem to have no effect on the delayed timing of the subtitles, but stopping and resuming the media again will sometimes change how many seconds off they're showing up for that current play session.

Expected behavior Embedded SRT subtitles should appear with timings consistent with the timestamps defined in the SRT and it should do this consistently regardless of whether the media is played from the beginning or resumed part-way through.

Logs N/A

Screenshots N/A

Connection Information Jellyfin server is running on the local network, currently over HTTPS but the same problem was present before when I was running over HTTP.

Additional context I use mkvtoolnix to remux SRT files into the HEVC main 10 mkv files that were encoded using Handbrake directly from ripped DVDs, blu-rays or UHD blu-rays. I haven't tested to see if non-embedded SRT files exhibit the same problems.

Zerva5 commented 1 year ago

I also experience this issue pretty regularly. Neither restarting Jellyfin or the RokuTV cause the subtitle timing to realign.

viown commented 1 year ago

I also experience this issue on external SRT files as well.

fungos commented 1 year ago

Same here, makes it pretty unusable unfortunately.