search

jellyfin / jellyfin-server-macos

The menu bar app and package for Jellyfin Server on macOS.
https://jellyfin.org
Mozilla Public License 2.0
60 stars 14 forks source link

Consider Removing Node and appdmg From Build #37

Closed anthonylavado closed 2 years ago

anthonylavado commented 4 years ago

I like appdmg because it uses a nice JSON file for config, but I am losing approx. 69 seconds to the whole process:

It's not too bad (since Node.js is already on the VM image), but I wonder if it can be better.

I should investigate if using "create-dmg", which is purely a shell script, provides any speed improvements.

anthonylavado commented 3 years ago

Looking into this again - appdmg is critically broken when using Node 14, so while it works for the time being on the Azure Pipeline, this should be considered deprecated and we need to move off of it sooner rather than later.

I have locally tested using create-dmg, and it ran with very little modification.

In the offline version of the build script, it went from:

appdmg jfdmg.json "Jellyfin.dmg"

to

create-dmg Jellyfin.app