Closed gnattu closed 3 months ago
It all looks good to me. As for ffmpeg, I feel like people might have used the homebrew one in the past. Now that we're bundling our own with significant improvements, I don't anticipate it being an issue.
If it is, we'll cross that bridge when we come to it.
This PR:
--ffmpeg
CLI parameter. This would make it impossible for our users to specify a custom ffmpeg binary, and if that is a supported use case, then an additional setting for this in this app is required.