Open bestlem opened 1 month ago
jellyfin-bot
commented
1 month ago Hi, it seems like your issue report has the following item(s) that need to be addressed:
This is an automated message, currently under testing. Please file an issue here if you encounter any problems.
gnattu
commented
1 month ago I note the mac app which is the one I got to tun still uses the old XDG paths.
Because it is impossible to migrate to new location just by moving folders. The databases will contain path info and if you just move them it will not work. So for a system with old installation the old path will be kept.
For similar reason, another migration breaks each and every current install is very very not feasible. You cannot just say "this is better" and breaks all current installs. No way.
bestlem
commented
1 month ago @gnattu I understand you However the code change in StartupHelpers.cs did change the paths so your reasoning has been rejected by those who changed the code. What is wrong here is that if you are going to change the code you should get it correct.
systemcrash
commented
1 month ago I note the mac app which is the one I got to tun still uses the old XDG paths.
The databases will contain path info and if you just move them it will not work.
Wait - so the full path is baked into the DB?
gnattu
commented
1 month ago However the code change in StartupHelpers.cs did change the paths so your reasoning has been rejected by those who changed the code.
It is a platform-independent change, not a macOS specific change. For both Windows and macOS, we are keeping the old path when an old path install is detected. For Linux, a lot of users use docker or other container technology so the default path does not matter any way, and for our official .deb packages we do overwrite the default paths to a pre-defined location but that path did not change for years iirc.
What is wrong here is that if you are going to change the code you should get it correct.
That change is made years ago. Now you want to make new changes. And users are already having installs with this path. Do you see the problem now?
gnattu
commented
1 month ago I note the mac app which is the one I got to tun still uses the old XDG paths.
The databases will contain path info and if you just move them it will not work.
Wait - so the full path is baked into the DB?
Yes, for a lot of items there will be an absolute path to your data dir.
bestlem
commented
1 month ago What is wrong here is that if you are going to change the code you should get it correct.
That change is made years ago. Now you want to make new changes. And users are already having installs with this path. Do you see the problem now?
No problem for the main errors - Logs and Caches - It does not matter what was there before.
Others yes migration is complex.
Please describe your bug
The default paths for macOS are not correct. See Helper/StartupHelpers.cs and Apple Documentation I think of the directory split as bing like XDG rather than windows but just in different place
The data directory (
~/Library/Application Support/Jellyfin) is correct but others aren'tDefinitely wrong Cache Directory should be
~/Library/Caches/Jellyfin- putting it there means that cleaning cache is consistent among apps and you don't have to hunt all over to find things taking up disk space and you can also easily ignore in backups Log Directory -~/Library/Logs/Jellyfin- just consistent with other apps.Arguably Config Directory -
~/Library/Preferences/JellyfinIf strictly following Apple guidelines all the directories Jellyfin mentioned above should be org.jellyfin.jellyfin or org.jellyfin.jellyfin-server but many apps don't bother.
Reproduction Steps
Reading code
I note the mac app which is the one I got to tun still uses the old XDG paths.
Jellyfin Version
Weekly unstable (please specify)
if other:
10.9.1 from Mac installer
Environment
Jellyfin logs
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct