[Issue]: 10.9 Windows installer is missing nssm.exe

CardenInsurance commented 3 months ago

Please describe your bug

When I upgraded to 10.9, I noticed the Jellyfin service disappeared from services.msc, so I could not access Jellyfin anymore. So I did a full uninstall and reinstall of 10.9, selecting the option to install as a service, and it appeared to install perfectly with no apparent error messages, but actually, it secretly failed to install the service again. Finally, I manually downloaded nssm.exe from the internet and copied it to c:\Program Files\Jellyfin\Server\nssm.exe, and then installed Jellyfin 10.9 again, and it worked - the service was created and started as expected.

I think nssm.exe must be missing from the 10.9 Windows AMD64 installer package, yet it is still needed by the installer.

(I thought I read somewhere that nssm was being replaced with native Windows service stuff, so maybe this is related)

Reproduction Steps

Make sure your Program Files\Jellyfin\Server folder is empty.

Do a clean install of Jellyfin 10.9 on Windows 11 64-bit from https://repo.jellyfin.org/?path=/server/windows/latest-stable.

Select the option to install as a service.

After installation, notice that the service did not get installed.

Jellyfin Version

10.9.0

if other:

No response

Environment

- OS: Windows 11 Pro 64

Jellyfin logs

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

jellyfin-bot commented 3 months ago

Hi, it seems like your issue report has the following item(s) that need to be addressed:

You are not running an up-to-date version of Jellyfin. Please update to the latest release.
The format of the environment section has been altered from the template.

This is an automated message, currently under testing. Please file an issue here if you encounter any problems.

Germs2004 commented 3 months ago

Here is a snippet from the installer's log text during an upgrade from 10.8.13 to 10.9. It appears that the service commands are being run but not error is being reported from them even though the service is not getting created:

Output folder: C:\Program Files\Jellyfin\Server\wwwroot\api-docs\swagger
Extract: custom.css... 100%
Output folder: C:\Program Files\Jellyfin\Server
Created uninstaller: C:\Program Files\Jellyfin\Server\Uninstall.exe
Execute: "C:\Program Files\Jellyfin\Server\nssm.exe" statuscode JellyfinServer
Jellyfin Server service statuscode, 0
Execute: "C:\Program Files\Jellyfin\Server\nssm.exe" install JellyfinServer "C:\Program Files\Jellyfin\Server\jellyfin.exe" --service --datadir \"J:\Jellyfin\"
Jellyfin Server Service install, 0
Execute: "C:\Program Files\Jellyfin\Server\nssm.exe" set JellyfinServer Start SERVICE_DELAYED_AUTO_START
Jellyfin Server Service setting (Start), 0
Execute: "C:\Program Files\Jellyfin\Server\nssm.exe" set JellyfinServer Description "Jellyfin Server: The Free Software Media System"
Jellyfin Server Service setting (Description), 0
Execute: "C:\Program Files\Jellyfin\Server\nssm.exe" set JellyfinServer DisplayName "Jellyfin Server"
Jellyfin Server Service setting (DisplayName), 0
Execute: "C:\Program Files\Jellyfin\Server\nssm.exe" set JellyfinServer Objectname "NT Authority\NetworkService"
Jellyfin Server service account change, 0
Execute: "C:\Program Files\Jellyfin\Server\nssm.exe" set JellyfinServer AppExit Default Exit
Jellyfin Server service exit action set, 0
Execute: "C:\Program Files\Jellyfin\Server\nssm.exe" start JellyfinServer
Jellyfin Server service start, 0
Completed

And I confirm that the nssm.exe is missing from the Program Files folder at the end of the 10.9 upgrade.

anthonylavado commented 3 months ago

Ah damn, will fix ASAP.

anthonylavado commented 3 months ago

That is to say - we're still NSSM for the moment. Not making the cutover to a native service yet.

anthonylavado commented 3 months ago

There's a new build up now, should include nssm.

Germs2004 commented 3 months ago

Ok, to test it (jellyfin_10.9.0-1_windows-x64.exe), I deleted my nssm.exe file and ran the installer to upgrade my 10.9.0 install. It successfully gave me my nssm.exe file back. Looks like it worked perfectly.

CardenInsurance commented 3 months ago

Thank you, the new build fixes the issue.

jellyfin / jellyfin-server-windows