search

jellyfin / jellyfin-server-windows

The Windows tray app and installer for Jellyfin Server on Windows.
https://jellyfin.org
MIT License
79 stars 26 forks source link

Windows installer failure in case of upgrade #123

Closed crankdoofus closed 2 months ago

crankdoofus commented 3 months ago

Seen while upgrading windows install from 10.8.x tp 10.9.0, then again from 10.9.0 -> 10.9.1 and now from 10.9.1 -> 10.9.2

  1. Jellyfin is running as service
  2. Running installer displays an error - Jellyfin is running, it needs to be closed.
  3. The service is stopped manually
  4. Installer is run again
  5. It detects existing installation
  6. Choose to retain data at the option
  7. Installer invokes silent uninstall as intended But now since the service was stopped prior to installation, the uninstaller fails. The handling isn't correct to recover from this error and installer just freezes doing nothing.

The only way to recover is to quit the installer and restart it. But now it has lost all the prior settings because the earlier silent uninstall cleaned up the registry before failing.

Let me know if you need more details. Clean installing 10.9.0 as a service and then trying to install 10.9.1 (or 10.9.2) should be able to repro the issue easily.

crankdoofus commented 3 months ago

same as https://github.com/jellyfin/jellyfin-server-windows/issues/124. Please determine the appropriate repo and close the other.

Repeating my comment here : this has been introduced from this commit - 6efa17b : https://github.com/jellyfin/jellyfin-server-windows/commit/6efa17bc3a5ec1c036c3d1dbee8fa8e7966f8e0c

@anthonylavado - this might have been introduced to close tray app before proceeding, it need a check for EXISTINGSERVICE

anthonylavado commented 2 months ago

Thanks for this. It wasn't to close the tray app, but to make sure Jellyfin is closed because people often don't do so before running the setup.

The installer is really a house of cards that I've tried to improve a little bit after so many years.

I'll group a fix to the logic for this along with the fix for an older .NET framework.

strigona commented 2 months ago

Hey, not sure if I'm missing something, but the issue is persisting with 10.9.4.

I tried both not stopping the server before running the installer (got the error), then shutdown the server and re-ran the installer and got the following error.

image

mattish91 commented 2 months ago

Hey, not sure if I'm missing something, but the issue is persisting with 10.9.4.

I tried both not stopping the server before running the installer (got the error), then shutdown the server and re-ran the installer and got the following error.

image

Gonna test this right now just to confirm this is still the case. Mainly since i wan't to be on the latest version as i have a script that i run to update everything automatically.

EDIT: Yes the issue persists. It still says Jellyfin service is running, not going to commit the upgrade as this will take some time to restore the config. Waiting for next release.

image