jellyfin / jellyfin-server-windows

The Windows tray app and installer for Jellyfin Server on Windows.
https://jellyfin.org
MIT License
79 stars 26 forks source link

[Issue]: Windows Service Installer expects Jellyfin to be stopped, then fails to stop it. #124

Closed strigona closed 2 months ago

strigona commented 3 months ago

Please describe your bug

I first noticed this issue when upgrading from 10.9.0 to 10.9.1 and the behaviour continued when updating again to 10.9.2.

The installer expects the Jellfyin service to be disabled, if it is running, I get this error: Screenshot 2024-05-18 170048

If Jellyfin is shutdown and the installer is run, it fails later on trying to shutdown the Jellyfin service. Screenshot 2024-05-18 170029

Jellyfin is left in an uninstalled state and I have to run the installer again to re-install Jellyfin and then everything is fine.

Reproduction Steps

  1. Windows 10
  2. Jellyfin 10.9.x server installed as a service
  3. Shutdown Jellyfin
  4. Run the 10.9.1 or 10.9.2 installer

Jellyfin Version

10.9.0

if other:

No response

Environment

- OS: Windows 10
- Linux Kernel: none
- Virtualization: none
- Clients:  N/A
- Browser:  N/A
- FFmpeg Version: N/A
- Playback Method: N/A
- Hardware Acceleration: N/A
- GPU Model: N/A
- Plugins: N/A
- Reverse Proxy: N/A
- Base URL: N/A
- Networking: N/A
- Storage: local

Jellyfin logs

Installer logs are in the description screenshot

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

jellyfin-bot commented 3 months ago

Hi, it seems like your issue report has the following item(s) that need to be addressed:

This is an automated message, currently under testing. Please file an issue here if you encounter any problems.

crankdoofus commented 3 months ago

+1 I incidentally raised the same bug under jellyfin-server-windows repo : https://github.com/jellyfin/jellyfin-server-windows/issues/123

strigona commented 3 months ago

Ah that's certainly a more appropriate repo.

Maintainers, feel free to close this in favour of the other issue.

crankdoofus commented 3 months ago

Did a bit more digging, this has been introduced from this commit - 6efa17b : https://github.com/jellyfin/jellyfin-server-windows/commit/6efa17bc3a5ec1c036c3d1dbee8fa8e7966f8e0c

@anthonylavado - this might have been introduced to close tray app before proceeding, it need a check for EXISTINGSERVICE

anthonylavado commented 2 months ago

Closing in favour of #123.