search

jellyfin / jellyfin-server-windows

The Windows tray app and installer for Jellyfin Server on Windows.
https://jellyfin.org
MIT License
79 stars 26 forks source link

Move tray app to .NET 4.7.2 #128

Closed anthonylavado closed 2 months ago

anthonylavado commented 2 months ago

This adds x64 Server 2019 support, for those who had issues.

We'll revisit a hybrid approach when we start building installer and tray for ARM.

Fixes #125 #119

nielsvanvelzen commented 2 months ago

Doesn't the tray app try to find jellyfin.exe it its own directory (CWD)? That would obviously fail after this PR.

anthonylavado commented 2 months ago

Does CI/nsis need to be updated for the subpath support?

NSIS does have paths for the tray app to make shortcuts, those are updated for the sub folder in here.

The CI has the same subfolder specified for the output which should mean it's okay.

anthonylavado commented 2 months ago

Doesn't the tray app try to find jellyfin.exe it its own directory (CWD)? That would obviously fail after this PR.

Good catch, I'll update that.

anthonylavado commented 2 months ago

@nielsvanvelzen Looks like we already covered that case a long time ago:

https://github.com/jellyfin/jellyfin-server-windows/blob/6fd2959fe42b9776bd758ece45d81ef7637e284c/Jellyfin.Windows.Tray/TrayApplicationContext.cs#L159

IIRC the tray app used to be in its own folder, a long time ago 🙂

anthonylavado commented 2 months ago

I just realized that windows-latest has a 4.7.2 targeting pack, but doesn't list it in .NET Core Tools (see here). Should I kick this back to 2019?