Correctly Use Network System Account

jellyfin / jellyfin-server-windows

The Windows tray app and installer for Jellyfin Server on Windows.

https://jellyfin.org

MIT License

80 stars 27 forks source link

Correctly Use Network System Account #39

Closed anthonylavado closed 3 years ago

anthonylavado commented 3 years ago

According to the NSSM readme (mirrored at kirillkovalenko/nssm, in cca8d28 a function was added to specify special account names.

Looking further at the code, this will look up the correct SID for us, avoiding any non-English Windows issues.

Fixes https://github.com/jellyfin/jellyfin/issues/2119.

CutterXYZ commented 3 years ago

Hi, is this fix included in 10.7RC3 ? Because I still get an error at the end of the installation script (exactly as described here).

anthonylavado commented 3 years ago

@CutterXYZ it is included when using the installer. I'm not sure that it fixes it if you are upgrading though, I think it might only work on new installs...

anthonylavado commented 3 years ago

Actually I'll have to check that I didn't build it with an outdated version by accident. Oops.

anthonylavado commented 3 years ago

@CutterXYZ You were right. Sorry about that. It's fixed in the build going up shortly.