search

jellyfin / jellyfin-server-windows

The Windows tray app and installer for Jellyfin Server on Windows.
https://jellyfin.org
MIT License
80 stars 27 forks source link

Build process warning : `... install function "fnc_setuptype_Show" not referenced ...`, is it worth any worry? #62

Closed NotesOfReality closed 2 years ago

NotesOfReality commented 2 years ago

I've followed the little guide in the readme to build an installer, the build process went totally fine, the installer works well, however the readme doesn't say anything about the following warning.

The process has output

Processed 1 file, writing output (x86-unicode):
6010: install function "fnc_setuptype_Show" not referenced - zeroing code (248-254) out

so I wonder if this shows there something which actually could have gone wrong, here's my whole PS session console output.

On a side note: the readme is very well written, thanks!

anthonylavado commented 2 years ago

Thank you for the compliment!

The reason for that message is that I have a draft screen for the installer that isn't used yet. NSIS is smart about it, and is zeroing out the reference in code because it's not being used.

NotesOfReality commented 2 years ago

I see, thanks for the clarification!