[bug]: "Open Jellyfin"-link in tray bar leads to a fixed port number

ajmayerrules commented 2 years ago

Please describe your bug

The "open Jellyfin"-link in the tray bar on windows always leads to the port 8096. I have changed my port and that link doesn't adapt to it. Not sure if it is fixable at all or if it is just a static link that can't adapt to port changes leads to when actual port is

Jellyfin Version

10.8.0

if other:

No response

Environment

- OS: win10
- Virtualization:
- Clients: Server
- Browser: 
- FFmpeg Version:
- Playback Method:
- Hardware Acceleration:
- Plugins:
- Reverse Proxy:
- Base URL:
- Networking:
- Storage:

Jellyfin logs

No response

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

billsargent commented 2 years ago

I can confirm this.

anthonylavado commented 2 years ago

Thanks for the catch. In 10.8 we moved the port from the system.xml file to the network.xml file. We had the tray app all set up for 10.7 still.

Have to move these lines: https://github.com/jellyfin/jellyfin-server-windows/blob/48e9c9bf4fc90665a465ba132f28aab3a155bada/Jellyfin.Windows.Tray/TrayApplicationContext.cs#L158-L162

To the the space in L169: https://github.com/jellyfin/jellyfin-server-windows/blob/48e9c9bf4fc90665a465ba132f28aab3a155bada/Jellyfin.Windows.Tray/TrayApplicationContext.cs#L165-L171

We plan on releasing a 10.8.1 very, very soon, so I'll make this fix a part of that.

jellyfin / jellyfin-server-windows