jellyfin / jellyfin-tizen

Jellyfin Samsung TV Client
https://jellyfin.org
1k stars 79 forks source link

Really choppy scrolling in menus #162

Closed HEPOSHEIKKI closed 8 months ago

HEPOSHEIKKI commented 1 year ago

Scrolling between items in libraries and the front page is really choppy and the animation is slow, is anyone else having this issue or is it just me?

IvanBernatovic commented 1 year ago

@HEPOSHEIKKI I have the same issue but it's a bit better if I disable images in the background.

kraM1tt commented 1 year ago

It's faster than Plex for me lol

TBE4034 commented 1 year ago

I have this same issue with no custom css or backdrop. Scrolling through movie listings is choppy and the only device with the issue is the Samsung TV. No issues on LG TV, MacBook, iPhones, etc.

HEPOSHEIKKI commented 1 year ago

@kraM1tt

It's faster than Plex for me lol

Can you please record this behavior so we can compare performance?

kraM1tt commented 1 year ago

I will do when I get a chance, can you post a video of your slow scrolling?

HEPOSHEIKKI commented 1 year ago

I will do when I get a chance, can you post a video of your slow scrolling?

Here is the performance on my TV: https://youtu.be/4HVnE1w0kM8 Here is the performance on an emulator: https://youtu.be/hSvaC-wYwlQ

kraM1tt commented 1 year ago

Ah that's really choppy, I assumed you meant the metadata/artwork loading in was causing choppy loading behaviour, I can confirm mine is the same as yours after just testing, sorry about the confusion.

Samsung RU7100 2019

HEPOSHEIKKI commented 1 year ago

Any idea what could be causing this?

bugbountyguy commented 1 year ago

Having the same issue with my Samsung TV, brand new build as of yesterday too... I tried the default theme + a custom theme, and don't have backgrounds. Tried to also:

No difference in performance, still super choppy.

Anyone know if any older versions for the TV might have better performance? Maybe worth building an older one that'd run smoother

alok-1019 commented 11 months ago

have someone found any solution to this ? Can we turn off animations while scrolling by using Custom CSS ? I believe animations during scrolling makes the scrolling choppy.

dmitrylyzo commented 11 months ago

Can we turn off animations while scrolling by using Custom CSS ?

https://github.com/jellyfin/jellyfin-web/blob/d06b631171d127bddbf05bdfe4dd7ea94cd74c1e/src/components/scrollManager.js#L479-L481

alok-1019 commented 11 months ago

Can we turn off animations while scrolling by using Custom CSS ?

https://github.com/jellyfin/jellyfin-web/blob/d06b631171d127bddbf05bdfe4dd7ea94cd74c1e/src/components/scrollManager.js#L479-L481

should I delete those lines and build wgt file for samsung tv ? function useSmoothScroll() { return !!browser.tizen; } should i delete these lines ?

dmitrylyzo commented 11 months ago

should I delete those lines and build wgt file for samsung tv ?

return false;
dmitrylyzo commented 11 months ago

But for now, could you please tell me what should I do to turn off animations by changing code ?

There is no other way to control smooth scrolling other than the function mentioned. 10.8 10.9 Returning false disables smooth scrolling. It is currently enabled only on Tizen.

alok-1019 commented 11 months ago

Returning false disables smooth scrolling. It is currently enabled only on Tizen.

Thanks. It worked. Now, Jellyfin on Samsung TV is a lot faster.

OdinVex commented 9 months ago

I don't think people mean "choppy" but rather non-smooth, eg. traditional. I prefer traditional but perhaps this should be implemented per person or device with the user being able to adjust this via UI.

HEPOSHEIKKI commented 9 months ago

But for now, could you please tell me what should I do to turn off animations by changing code ?

There is no other way to control smooth scrolling other than the function mentioned. 10.8 10.9 Returning false disables smooth scrolling. It is currently enabled only on Tizen.

I thought I replied to this already, weird...

Well anyway, I tried this a few weeks ago (unless I hallucinated everything, my short term memory is lacking) and it ran a lot better. If this can be made default (which it should be looking at the code??) I consider this issue ready to be closed.