search

jellyfin / jellyfin-tizen

Jellyfin Samsung TV Client
https://jellyfin.org
999 stars 79 forks source link

Added MediaPlayPause listener #166

Closed vov4uk closed 1 year ago

vov4uk commented 1 year ago

Play/Pause button will work

dmitrylyzo commented 1 year ago

IIRC, when MediaPlayPause is enabled, the OSD hint (with 5 virtual buttons: FastForward, Rewind, Previous track, Next track, Play/Pause) for Smart Remote doesn't work.

UPD: https://github.com/jellyfin/jellyfin-tizen/issues/11#issuecomment-612685979

vov4uk commented 1 year ago

I'm not familiar with Tizen development - but after this fix, my UE49KU6470 works correctly with my remote control

dmitrylyzo commented 1 year ago

What remote control is used?

Remote Control Samsung Smart Remote

According to the UE49KU6470 manual, its Smart Remote should show on-screen playback control when pressing Play/Pause like other models.

Samsung may require this button to work as Play/Pause to pass certification, but this is a loss of functionality, imo. At the same time, on-screen control functionality exists on the video OSD bottom panel. :man_shrugging:

vov4uk commented 1 year ago

I use "Samsung Smart Remote". If you have any concerns, feel free to cancel the pull request.

TomasMonkevic commented 1 year ago

I can confirm that the play pause button doesn't work on the new Samsung Smart Remote. Only the middle press in the circle works

mullerdavid commented 1 year ago

I agree it's a loss of functionality, but personally I prefer the plain play/pause functionality. The best of both would be to implement some kind of option for it that can be set in the app.

dmitrylyzo commented 1 year ago

Superseded by #184