jellyfin / jellyfin-vue

A modern web client for Jellyfin based on Vue
https://jellyfin.org
GNU General Public License v3.0
1.26k stars 226 forks source link

Transitions between pages with background doesn't look good #1687

Closed ferferga closed 2 years ago

ferferga commented 2 years ago

Description of the bug

When transitioning between pages that have a background (i.e item details page), the background is cleared when leaving the page and reappears in the new page.

This leaves an awkward transition where everything should be transitioning smoothly.

Steps to reproduce

  1. Go to an item page
  2. Select a related item or a person from the cast

Expected behavior

Old background fades out to the new background

Logs

No response

Screenshots

No response

Platform

Windows

Browser

Edge

Jellyfin server version

10.7.7

Additional context

No response

ThibaultNocchi commented 2 years ago

To me, it doesn't look too bad but I can understand how someone would find it weird

ferferga commented 2 years ago

Clone this PR and see what I mean when looking at the nav drawer lol: https://github.com/jellyfin/jellyfin-vue/pull/1677

I think we can fix this by using meta tags and handling all the opacity changing by a middleware. We remove all clearBackdrop from destroyed hooks in pages and leave the middleware to decide (if next route has background, do nothing, if it doesn't, dispatch clearBackdrop).

That would also clean up most of the pages that use backgrounds (as background changing will be a matter of two lines instead of the mapAction and all the boilerplate). Only pages that need to change the background while are mounted will need that.

ThibaultNocchi commented 2 years ago

Ok so I tried, I still don't think it's too problematic. But if you bring a nice fix there's np :)

ferferga commented 2 years ago

@ThibaultNocchi fix in #1690